Warn on RunTask failures #93
Conversation
|
Added unittests across index, not terribly proud of them though |
index.js
Outdated
| @@ -74,6 +74,12 @@ module.exports = function (options, cb) { | |||
| return taskRunner.runPromisified(params); | |||
| }) | |||
| .then((taskDefinition) => { | |||
| if (taskDefinition.failures) { | |||
| console.error("Task failed to launch:") | |||
There was a problem hiding this comment.
I think it's fine to just throw the error - anything interested should catch it and log as appropriate. This is intended to be used as a library after all.
package.json
Outdated
| @@ -10,7 +10,7 @@ | |||
| "ecs-task-runner": "./bin/ecs-task-runner" | |||
| }, | |||
| "scripts": { | |||
| "test": "NODE_ENV=test ./node_modules/.bin/mocha --recursive" | |||
| "test": "NODE_ENV=test ./node_modules/.bin/mocha --parallel --recursive" | |||
There was a problem hiding this comment.
would avoid parallel usage, I remember some problems with one of these codebases where it was not really concurrency safe
There was a problem hiding this comment.
Well, this is one of them apparently. I removed parallel and now tests won't pass lol
There was a problem hiding this comment.
m-radzikowski/aws-sdk-client-mock#64
Apparently mocha has weird behavior with aws-sdk-client-mock, shuffling up the mockClient invocations resolves it.
| }); | ||
|
|
||
| try { | ||
| await index(options); |
There was a problem hiding this comment.
why not something like expect(index(options).to.throw ... ?
There was a problem hiding this comment.
It didn't work ¯_(ツ)_/¯
expect.js hasn't been updated in a decade, maybe they don't support promises?
There was a problem hiding this comment.
I think mocha and expect.js might be kind dead projects. Something that annoyed my the whole time in working on this is that errors were always "test timed out" and apparently that's just mocha being terrible with promises.
mochajs/mocha#2640
| ecsMock.on(RunTaskCommand).callsFake(async params => { | ||
| expect(params.taskDefinition).to.eql(options.taskDefinitionArn) | ||
|
|
||
| eofSet(params.overrides.containerOverrides[0].command[2].split(' ')[9]) |
There was a problem hiding this comment.
I don't really get what this does
There was a problem hiding this comment.
I'll add a comment, but yeah this is ugliest bit of this. This is the only place we can grab the random value the log stuff uses to detect the end of the task run.
Might want to also log, I'll have to devise a way to cause the API to fail to test this