Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidated GET-based Open Redirect #19

Merged
merged 2 commits into from
May 25, 2017
Merged

Consolidated GET-based Open Redirect #19

merged 2 commits into from
May 25, 2017

Conversation

ryancblack
Copy link
Contributor

Implementing #13

plr0man
plr0man approved these changes May 21, 2017
View reviewed changes
Copy link
Contributor

@plr0man plr0man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!
Side note for @maschwenk: all three deleted variants get_based_all_users, get_based_authenticated, get_based_unauthenticated map to the new get_based variant

@plr0man plr0man mentioned this pull request May 21, 2017
Closed
@ryancblack ryancblack added this to the v1.2 milestone May 21, 2017
@barnett barnett mentioned this pull request May 25, 2017
Closed
@barnett barnett merged commit 76a9d28 into master May 25, 2017
@barnett barnett deleted the revise-open-redirect branch May 25, 2017 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschwenk maschwenk maschwenk approved these changes

@barnett barnett barnett approved these changes

@plr0man plr0man plr0man approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryancblack @maschwenk @barnett @plr0man