Improve performance of input-raw and improve handing of large payloads #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2015
buger
added a commit
that referenced
this pull request
Jul 11, 2015
Improve performance of input-raw and improve handing of large payloads
|
Included into v0.9.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syscallpackage to read from sockets, avoiding net/http overhead.UPDATE:
For the future references: Initially i tried to directly use syscall package to read from sockets but found that whole golang IO have global lock, and if you use syscall.Socket directly, you can't use net package, even in other threads, otherwise you will experience locks. Also after checking code i found that
ReadFromfunction is very close to the original syscall.Recvfrom call, and its ok to use it here.