Fixed Wrong parameters entered by user (#703) #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendly tips can help users avoid this problem
|
|
slimus
requested changes
May 27, 2020
input_raw.go
Outdated
| @@ -78,7 +78,7 @@ func (i *RAWInput) listen(address string) { | |||
| host, port, err := net.SplitHostPort(address) | |||
|
|
|||
| if err != nil { | |||
| log.Fatal("input-raw: error while parsing address", err) | |||
| log.Fatalf("input-raw: error while parsing address: %s , err: %v" , address, err) | |||
There was a problem hiding this comment.
err already has address. I think it should smth like
log.Fatalf("input-raw: error while parsing address: %s", err)
slimus
reviewed
May 29, 2020
xingren23
pushed a commit
to xingren23/goreplay
that referenced
this pull request
Sep 4, 2021
Fixed Wrong parameters entered by user (buger#703)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friendly tips can help users avoid this problem
#703