Sort tcp packets #94
Sort tcp packets #94
Conversation
Conflicts: emitter.go
| i++ | ||
| } | ||
|
|
||
| sort.Ints(mk) |
There was a problem hiding this comment.
What is the difference from sorting that i already doing?
There was a problem hiding this comment.
I may be misreading but it appears that the current method collects an
integer array of the index positions of the packets within a message and
then composes the byte array in the order which the packets came in. The
new method sorts the packet array based off of each packet's Seq number and
then composes the byte array.
On Apr 23, 2014 2:00 AM, "Leonid Bugaev" notifications@github.com wrote:
In raw_socket_listener/tcp_message.go:
- i := 0
- for k, _ := range t.packets {
mk[i] = ki++- }
- sort.Ints(mk)
What is the difference from sorting that i already doing?
Reply to this email directly or view it on GitHubhttps://github.com//pull/94/files#r11887582
.
There was a problem hiding this comment.
Oh, you know i realized bug. Yes, you pull request should fix issue, thanks!
This should fix #92. I upped the message timeout slightly to allow some larger POSTS to move all their packets more successfully.
Thanks for the help @ElPeque