Change ArrayEach CB Signature to Return Error #156
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Changes the callback function signature of
ArrayEach
to return an error. It currently takes an error as input even thoughArrayEach
never passes a non-nil error into it. It should be more likeObjectEach
which returns an error from its callback function.I had to fix
Dockerfile
andbenchmark/benchmark_codecgen.go
in order to get benchmarks to run.(...it makes this repository seem very under-maintained).
Benchmark before change: DID NOT WORK
Benchmark after change: