Bug: Closing connection closes already closed PGSQLPreparedStatement #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tatement. Remove flawed `PGSQLPreparedStatement::close()` method. This method is nearly identical to `PGSQLStatement::close()`, however, it lacks a call to `conn.onStatementClosed(this)`. Due to this deficiency, the connection will attempt to close the statement a 2nd time when it is closed, resulting in an exception being thrown. By erasing the implementation in `PGSQLPreparedStatement`, the correct implemention in `PGSQLStatement` can be used.
SingingBush
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove flawed
PGSQLPreparedStatement::close()method. This method is nearly identical toPGSQLStatement::close(), however, it lacks a call toconn.onStatementClosed(this). Due to this deficiency, the connection will attempt to close the statement a 2nd time when it is closed, resulting in an exception being thrown.By erasing the implementation in
PGSQLPreparedStatement, the correct implemention inPGSQLStatementcan be used.