bmi_audio driver updates #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the bmi_audio driver generated audio only on one channel. This was a result of the fact that the bit clock to frame clock ratio was wrong. With the clocking and McBSP DMA transfer scheme chosen in the bmi_audio driver, the bit clock must match the frame clock exactly (e.g. with 16 bits sample width, the bit clock must be 32 times the frame clock).
|
I'm closing this pull request again - I think that the driver, as it stands, is simply using the wrong clock (48Mhz) for audio. Instead, the clock must be generated by the codec, which has a PLL that can be used to match many sample rates. tlv320aic3x.c has code to set up the clock generator properly, and I'm going to use that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
this is my initial update to the bmi_audio driver, mainly for review and discussion. It fixes the problem that audio was only coming out of the left channel. I think I've pretty much drilled myself to the bottom of the problem, but I'd welcome any input on my proposed changes or any other thoughts that you may have.
Thanks!
Hans