Merge branch 'master' into client-breadcrumbs-code-cov

bugsnag · May 2, 2018 · 024aa21 · 024aa21
2 parents b49db1a + a5f103a
commit 024aa21
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/sdk/build.gradle b/sdk/build.gradle
@@ -25,8 +25,9 @@ android {
     }
 
     lintOptions {
-        disable 'DefaultLocale', 'Typos'
         abortOnError true
+        warningsAsErrors true
+        checkAllWarnings true
     }
 }
 

diff --git a/sdk/src/androidTest/java/com/bugsnag/android/ClientTest.java b/sdk/src/androidTest/java/com/bugsnag/android/ClientTest.java
@@ -4,6 +4,7 @@
 import static com.bugsnag.android.BugsnagTestUtils.getSharedPrefs;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 
 import android.content.Context;
@@ -260,5 +261,20 @@ public void testClearBreadcrumbs() {
         client.clearBreadcrumbs();
         assertEquals(0, client.breadcrumbs.store.size());
     }
+
+    @Test
+    public void testClientAddToTab() {
+        Client client = generateClient();
+        client.addToTab("drink", "cola", "cherry");
+        assertNotNull(client.getMetaData().getTab("drink"));
+    }
 
+    @Test
+    public void testClientClearTab() {
+        Client client = generateClient();
+        client.addToTab("drink", "cola", "cherry");
+
+        client.clearTab("drink");
+        assertTrue(client.getMetaData().getTab("drink").isEmpty());
+    }
 }
diff --git a/sdk/src/main/java/com/bugsnag/android/StrictModeHandler.java b/sdk/src/main/java/com/bugsnag/android/StrictModeHandler.java
@@ -1,5 +1,6 @@
 package com.bugsnag.android;
 
+import android.annotation.SuppressLint;
 import android.support.annotation.Nullable;
 import android.text.TextUtils;
 
@@ -27,6 +28,7 @@ class StrictModeHandler {
 
     private static final String STRICT_MODE_CLZ_NAME = "android.os.StrictMode";
 
+    @SuppressLint("UseSparseArrays")
     private static final Map<Integer, String> POLICY_CODE_MAP = new HashMap<>();
 
     static {