refactor: initialise filestore in unit tests

initialises a filestore directly in unit tests, rather than relying on the client. this should reduce side effects (e.g. error flushing on launch) which may have led to flakiness
bugsnag · Apr 26, 2018 · 761cb3d · 761cb3d
1 parent 0672281
commit 761cb3d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/sdk/src/androidTest/java/com/bugsnag/android/ErrorStoreTest.java b/sdk/src/androidTest/java/com/bugsnag/android/ErrorStoreTest.java
@@ -40,9 +40,8 @@ public class ErrorStoreTest {
      */
     @Before
     public void setUp() throws Exception {
-        Client client = new Client(InstrumentationRegistry.getContext(), "api-key");
-        config = client.config;
-        errorStore = client.errorStore;
+        config = new Configuration("api-key");
+        errorStore = new ErrorStore(config, InstrumentationRegistry.getContext());
         assertNotNull(errorStore.storeDirectory);
         errorStorageDir = new File(errorStore.storeDirectory);
         FileUtils.clearFilesInDir(errorStorageDir);

diff --git a/sdk/src/androidTest/java/com/bugsnag/android/SessionStoreTest.java b/sdk/src/androidTest/java/com/bugsnag/android/SessionStoreTest.java
@@ -5,6 +5,7 @@
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 
+import android.content.Context;
 import android.support.test.InstrumentationRegistry;
 import android.support.test.filters.SmallTest;
 import android.support.test.runner.AndroidJUnit4;
@@ -29,8 +30,9 @@ public class SessionStoreTest {
      */
     @Before
     public void setUp() throws Exception {
-        Client client = new Client(InstrumentationRegistry.getContext(), "api-key");
-        SessionStore sessionStore = client.sessionStore;
+        Configuration config = new Configuration("api-key");
+        Context context = InstrumentationRegistry.getContext();
+        SessionStore sessionStore = new SessionStore(config, context);
         assertNotNull(sessionStore.storeDirectory);
         storageDir = new File(sessionStore.storeDirectory);
         FileUtils.clearFilesInDir(storageDir);

diff --git a/sdk/src/androidTest/java/com/bugsnag/android/SessionTrackingPayloadTest.java b/sdk/src/androidTest/java/com/bugsnag/android/SessionTrackingPayloadTest.java
@@ -36,8 +36,9 @@ public class SessionTrackingPayloadTest {
     @Before
     public void setUp() throws Exception {
         Context context = InstrumentationRegistry.getContext();
-        Client client = new Client(context, "api-key");
-        sessionStore = client.sessionStore;
+        Configuration config = new Configuration("api-key");
+        sessionStore = new SessionStore(config, context);
+
         Assert.assertNotNull(sessionStore.storeDirectory);
         storageDir = new File(sessionStore.storeDirectory);
         FileUtils.clearFilesInDir(storageDir);