send -> shouldRecord

bugsnag · Feb 5, 2018 · 887b79d · 887b79d
1 parent 226675b
commit 887b79d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/sdk/src/androidTest/java/com/bugsnag/android/BeforeRecordBreadcrumbsTest.java b/sdk/src/androidTest/java/com/bugsnag/android/BeforeRecordBreadcrumbsTest.java
@@ -38,7 +38,7 @@ public void noCallback() throws Exception {
     public void falseCallback() throws Exception {
         client.beforeRecordBreadcrumb(new BeforeRecordBreadcrumb() {
             @Override
-            public boolean send(@NonNull Breadcrumb breadcrumb) {
+            public boolean shouldRecord(@NonNull Breadcrumb breadcrumb) {
                 return false;
             }
         });
@@ -50,7 +50,7 @@ public boolean send(@NonNull Breadcrumb breadcrumb) {
     public void trueCallback() throws Exception {
         client.beforeRecordBreadcrumb(new BeforeRecordBreadcrumb() {
             @Override
-            public boolean send(@NonNull Breadcrumb breadcrumb) {
+            public boolean shouldRecord(@NonNull Breadcrumb breadcrumb) {
                 return true;
             }
         });
@@ -62,13 +62,13 @@ public boolean send(@NonNull Breadcrumb breadcrumb) {
     public void multipleCallbacks() throws Exception {
         client.beforeRecordBreadcrumb(new BeforeRecordBreadcrumb() {
             @Override
-            public boolean send(@NonNull Breadcrumb breadcrumb) {
+            public boolean shouldRecord(@NonNull Breadcrumb breadcrumb) {
                 return true;
             }
         });
         client.beforeRecordBreadcrumb(new BeforeRecordBreadcrumb() {
             @Override
-            public boolean send(@NonNull Breadcrumb breadcrumb) {
+            public boolean shouldRecord(@NonNull Breadcrumb breadcrumb) {
                 return false;
             }
         });
@@ -81,14 +81,14 @@ public void ensureBothCalled() throws Exception {
         final int[] count = {0};
         client.beforeRecordBreadcrumb(new BeforeRecordBreadcrumb() {
             @Override
-            public boolean send(@NonNull Breadcrumb breadcrumb) {
+            public boolean shouldRecord(@NonNull Breadcrumb breadcrumb) {
                 count[0] += 1;
                 return true;
             }
         });
         client.beforeRecordBreadcrumb(new BeforeRecordBreadcrumb() {
             @Override
-            public boolean send(@NonNull Breadcrumb breadcrumb) {
+            public boolean shouldRecord(@NonNull Breadcrumb breadcrumb) {
                 count[0] += 1;
                 return true;
             }
@@ -106,7 +106,7 @@ public void ensureOnlyCalledOnce() throws Exception {
 
         BeforeRecordBreadcrumb beforeRecordBreadcrumb = new BeforeRecordBreadcrumb() {
             @Override
-            public boolean send(@NonNull Breadcrumb breadcrumb) {
+            public boolean shouldRecord(@NonNull Breadcrumb breadcrumb) {
                 count[0] += 1;
                 return true;
             }
@@ -123,7 +123,7 @@ public void checkBreadrumbFields() throws Exception {
 
         BeforeRecordBreadcrumb beforeRecordBreadcrumb = new BeforeRecordBreadcrumb() {
             @Override
-            public boolean send(@NonNull Breadcrumb breadcrumb) {
+            public boolean shouldRecord(@NonNull Breadcrumb breadcrumb) {
                 count[0] += 1;
                 assertEquals("Hello", breadcrumb.getName());
                 assertEquals(BreadcrumbType.MANUAL, breadcrumb.getType());

diff --git a/sdk/src/main/java/com/bugsnag/android/BeforeRecordBreadcrumb.java b/sdk/src/main/java/com/bugsnag/android/BeforeRecordBreadcrumb.java
@@ -27,6 +27,6 @@ public interface BeforeRecordBreadcrumb {
      * @param breadcrumb the breadcrumb to be captured by Bugsnag
      * @see Breadcrumb
      */
-    boolean send(@NonNull Breadcrumb breadcrumb);
+    boolean shouldRecord(@NonNull Breadcrumb breadcrumb);
 
 }
diff --git a/sdk/src/main/java/com/bugsnag/android/Client.java b/sdk/src/main/java/com/bugsnag/android/Client.java
@@ -1055,7 +1055,7 @@ private boolean runBeforeNotifyTasks(Error error) {
     private boolean runBeforeBreadcrumbTasks(@NonNull Breadcrumb breadcrumb) {
         for (BeforeRecordBreadcrumb beforeRecordBreadcrumb : config.getBeforeRecordBreadcrumbTasks()) {
             try {
-                if (!beforeRecordBreadcrumb.send(breadcrumb)) {
+                if (!beforeRecordBreadcrumb.shouldRecord(breadcrumb)) {
                     return false;
                 }
             } catch (Throwable ex) {