Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make event.unhandled overridable for JVM errors #1025

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Dec 7, 2020

Goal

This makes it possible to override the unhandled property for JVM errors. This allows users to discard certain events from contributing to the stability score.

Changeset

  • Renamed HandledState to SeverityReason for greater alignment with notifier spec
  • Added setter to Event which allows altering the unhandled state
  • If the unhandled has been changed, unhandledOverridden is serialized in the JSON payload
  • Updated DeliveryDelegate so that it caches unhandled errors even if a user has set their unhandled state to false

Testing

Updated and added to existing unit test coverage for unhandled state serialization. Added new E2E tests to assert that unhandled can be overwritten both ways, which have been run locally.

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Dec 7, 2020

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1441.41 1361.3
arm64_v8a 369.25 287.33
armeabi 348.77 266.84
armeabi_v7a 332.38 250.47
x86 410.2 328.28
x86_64 389.72 307.8

Generated by 🚫 Danger

@fractalwrench fractalwrench force-pushed the PLAT-5489/unhandled-override-jvm branch from 7dfab9c to 4ed8f7a Compare December 7, 2020 15:52
@fractalwrench fractalwrench changed the base branch from next to integration/road-732-unhandled-override December 7, 2020 15:58
@fractalwrench fractalwrench changed the title [WIP] Make unhandled overridable on JVM errors Make event.unhandled overridable for JVM errors Dec 7, 2020
@fractalwrench fractalwrench changed the title Make event.unhandled overridable for JVM errors Make event.unhandled overridable for JVM errors Dec 7, 2020
@fractalwrench fractalwrench force-pushed the PLAT-5489/unhandled-override-jvm branch from 4ed8f7a to ea66407 Compare December 7, 2020 16:51
@fractalwrench fractalwrench marked this pull request as ready for review December 7, 2020 17:21
Copy link
Contributor

@tomlongridge tomlongridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be a couple of MR changes - is that deliberate? (including some sort of change on features/fixtures/mazerunner/gradlew)

@fractalwrench fractalwrench force-pushed the PLAT-5489/unhandled-override-jvm branch from ea66407 to abc66f9 Compare December 8, 2020 15:14
@fractalwrench
Copy link
Contributor Author

Addressed inline review comments. There are two parts to the mazerunner changes which are intentional:

  1. Update Gemfile and Gemfile.lock so that they point at the latest mazerunner when running tests locally
  2. Make the gradle wrapper executable through chmod +x which allows for the mazerunner test fixture to be built from the command line

@fractalwrench fractalwrench merged commit a51804c into integration/road-732-unhandled-override Dec 9, 2020
@fractalwrench fractalwrench deleted the PLAT-5489/unhandled-override-jvm branch December 9, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants