String copy and JNI fixes #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
string-jni-safety
branch
from
d3a99d8
to
0b1463a
Compare
…y into one function. Remove custom string length functions. Return NULL or default values from JNI-to-JVM calls when an exception occurs.
kstenerud
force-pushed
the
string-jni-safety
branch
from
0b1463a
to
cd339d7
Compare
fractalwrench
approved these changes
Feb 19, 2021
This was referenced Mar 3, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
JNI-to-JVM calls could return garbage data if an exception is thrown by the JVM.
String copies were not all uniform, and in some cases would not be null terminated.
Some string functions (such as length calculation) are better handled by the standard library.
Design
Testing
Re-ran unit tests and e2e tests