Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache value of app.backgroundWorkRestricted #1275

Merged
merged 1 commit into from Jun 17, 2021

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Jun 17, 2021

Goal

Caches the value of app.backgroundWorkRestricted as it is unlikely to change over a session. This should improve the performance of subsequent Bugsnag.notify() calls as the API call took ~3ms on a OnePlus 7.

Testing

Ran the example app with the artefact and confirmed the field is reported correctly.

@fractalwrench fractalwrench marked this pull request as ready for review June 17, 2021 10:17
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit e097884 into next Jun 17, 2021
@fractalwrench fractalwrench deleted the PLAT-6741/bg-work-cache branch June 17, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants