React Native: allow serializing enabledBreadcrumbTypes as null #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
force-pushed
the
rn-config-tweak
branch
from
e02a7dc
to
5bc9507
Compare
imjoehaines
approved these changes
Jul 13, 2021
| @@ -35,6 +35,9 @@ public void serialize(Map<String, Object> map, ImmutableConfig config) { | |||
| } | |||
|
|
|||
| private Collection<String> serializeBreadrumbTypes(ImmutableConfig config) { | |||
| if (config.getEnabledBreadcrumbTypes() == null) { | |||
| return null; | |||
| } | |||
| Collection<String> crumbTypes = new HashSet<>(); | |||
| Set<BreadcrumbType> types = config.getEnabledBreadcrumbTypes(); | |||
| if (types != null) { | |||
There was a problem hiding this comment.
I think we could remove this guard as well
fractalwrench
force-pushed
the
rn-config-tweak
branch
from
5bc9507
to
b3c8784
Compare
Android notifier sizes
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Serializes
enabledBreadcrumbTypesasnullwhen it is null in config, rather than as an empty list. The specification states that null is equivalent to having specified automatic capture of all breadcrumb types.Testing
Verified using the RN test fixtures that an automatic breadcrumb is sent through when the
enabledBreadcrumbTypesis null: