Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert DependencyModule performance change #1696

Merged
merged 1 commit into from May 24, 2022

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented May 24, 2022

Goal

Revert #1680 to avoid deadlocks in Bugsnag.start.

… `resolvedValueOf` to avoid reflection during startup and reduce the number of objects that need to be allocated"

This reverts commit 1d930a8
@lemnik lemnik requested a review from kstenerud May 24, 2022 08:33
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1856.87 1606.18
arm64_v8a 651.66 401.8
armeabi_v7a 586.13 340.37
x86 725.37 475.51
x86_64 696.71 446.85

Generated by 🚫 Danger

@lemnik lemnik marked this pull request as ready for review May 24, 2022 09:00
@lemnik lemnik merged commit 3597e9e into next May 24, 2022
@lemnik lemnik deleted the PLAT-8497/anr-in-datacollectionmodule branch May 24, 2022 09:53
@lemnik lemnik mentioned this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants