Avoid running over the end of the maps file buffer
#1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r when parsing lines
lemnik
force-pushed
the
PLAT-9472/rare-refresh-segv
branch
from
5ae12d6
to
9ee4e5c
Compare
Android notifier sizes
Generated by 🚫 Danger |
kstenerud
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Avoid buffer overruns (and the resulting
SIGSEGV) when parsing the/proc/<pid>/mapsfiles.Changeset
Updated our internal
libunwindstackto a version that checks the length of the buffer when parsing the file. If the end of the buffer is reached while parsing a line, the file is rejected as invalid data.Testing
Manual saturation testing