Trivial improvements to RootDetector #1815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Slightly improve the
RootDetector
overhead.Changeset
any
instead ofcount() > 0
to early exit when checking the system build-propsvolatile boolean
instead ofAtomicBoolean
to check library-load (no CAS operations are used)Reader.isNotBlank
function instead ofReader.readText().isNotBlank()
Testing
Modified the unit test, and added a new test for the
which su
check returning a blank (but not empty) string