Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDK and ANR detection warning messages #1832

Merged
3 commits merged into from Apr 18, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 18, 2023

Goal

When NDK and ANR plugins are excluded, there will not warning messages in the log when application is initialised.

Changeset

Added condition to make sure ANR and NDR crash warning message shows correctly.

Testing

Manual test

@ghost ghost requested a review from lemnik April 18, 2023 12:45
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Apr 18, 2023

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1921.48 1696.72
arm64_v8a 680.33 459.15
armeabi_v7a 614.8 393.62
x86 754.04 532.86
x86_64 725.38 504.19

Generated by 🚫 Danger

@ghost ghost force-pushed the PLAT-9508/fix_previous_NDK_and_ANR_detection_warnings branch 5 times, most recently from 26cab4b to f6d79fd Compare April 18, 2023 13:48
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Pending Lints

@ghost ghost force-pushed the PLAT-9508/fix_previous_NDK_and_ANR_detection_warnings branch from f6d79fd to 300fcf5 Compare April 18, 2023 14:48
@ghost ghost merged commit ddaab36 into next Apr 18, 2023
23 checks passed
@ghost ghost deleted the PLAT-9508/fix_previous_NDK_and_ANR_detection_warnings branch April 18, 2023 16:20
@lemnik lemnik mentioned this pull request May 11, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants