Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise session tracker for foreground activities #1838

Conversation

ghost
Copy link

@ghost ghost commented May 3, 2023

Goal

Optimise SessionTracer to reduce the overhead in calculating the current context Activity

Changeset

Optimised session tracker, to spend less time and memory for getting content activity, and added synchronise block to avoid the issue casing by potential multi threads

Testing

Relied on existing tests

@ghost ghost requested a review from lemnik May 3, 2023 12:54
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1922.8 1696.73
arm64_v8a 680.33 459.15
armeabi_v7a 618.9 393.62
x86 758.14 532.86
x86_64 725.38 504.19

Generated by 🚫 Danger

@lemnik lemnik changed the title Optimise session tracker for fore ground activities Optimise session tracker for foreground activities May 3, 2023
…d memory for getting content activity. Also added synchronise block to avoid the issue casing by potential multi threads.
@ghost ghost force-pushed the PLAT-8474_fixed_previous_Optimise_SessionTracker_by_removing_the_use_of_ConcurrentLinkedQueue branch from 9be31cb to 1d679c5 Compare May 3, 2023 15:50
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit d883e15 into next May 3, 2023
23 checks passed
@ghost ghost deleted the PLAT-8474_fixed_previous_Optimise_SessionTracker_by_removing_the_use_of_ConcurrentLinkedQueue branch May 3, 2023 16:28
@lemnik lemnik mentioned this pull request May 11, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants