Support changing apiKey in session callback #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
PLAT-4974_Support_change_of_API_key_in_session_callback
branch
from
80690c1
to
dfa4ce6
Compare
Android notifier sizes
Generated by 🚫 Danger |
ghost
force-pushed
the
PLAT-4974_Support_change_of_API_key_in_session_callback
branch
7 times, most recently
from
24f48e7
to
c98a7e0
Compare
lemnik
reviewed
Jun 5, 2023
bugsnag-android-core/src/androidTest/java/com/bugsnag/android/SessionV2PayloadTest.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/test/java/com/bugsnag/android/EventSerializationTest.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/test/java/com/bugsnag/android/SessionFilenameTest.kt
Outdated
Show resolved
Hide resolved
...enarios/src/main/java/com/bugsnag/android/mazerunner/scenarios/SessionApiKeyResetScenario.kt
Show resolved
Hide resolved
ghost
force-pushed
the
PLAT-4974_Support_change_of_API_key_in_session_callback
branch
3 times, most recently
from
335f66e
to
97bf5c0
Compare
lemnik
reviewed
Jun 6, 2023
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionFilenameInfo.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionFilenameInfo.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionFilenameInfo.kt
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
PLAT-4974_Support_change_of_API_key_in_session_callback
branch
3 times, most recently
from
7a66c9f
to
d2ac0c1
Compare
lemnik
reviewed
Jun 6, 2023
ghost
force-pushed
the
PLAT-4974_Support_change_of_API_key_in_session_callback
branch
3 times, most recently
from
03a3f77
to
1fc471d
Compare
lemnik
changed the title
lemnik
reviewed
Jun 15, 2023
ghost
force-pushed
the
PLAT-4974_Support_change_of_API_key_in_session_callback
branch
from
1fc471d
to
27d7278
Compare
lemnik
requested changes
Jun 19, 2023
bugsnag-android-core/src/main/java/com/bugsnag/android/Session.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionFilenameInfo.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionFilenameInfo.kt
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionFilenameInfo.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionFilenameInfo.kt
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
PLAT-4974_Support_change_of_API_key_in_session_callback
branch
4 times, most recently
from
6ef96eb
to
cf69006
Compare
lemnik
reviewed
Jun 22, 2023
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionFilenameInfo.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionFilenameInfo.kt
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
PLAT-4974_Support_change_of_API_key_in_session_callback
branch
3 times, most recently
from
b8f5026
to
07021dc
Compare
ghost
force-pushed
the
PLAT-4974_Support_change_of_API_key_in_session_callback
branch
from
07021dc
to
66dc291
Compare
lemnik
reviewed
Jun 28, 2023
bugsnag-android-core/src/main/java/com/bugsnag/android/SessionFilenameInfo.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/Session.java
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
PLAT-4974_Support_change_of_API_key_in_session_callback
branch
from
66dc291
to
70a7bfc
Compare
lemnik
approved these changes
Jul 4, 2023
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Session has it's own apikey and can be reset in session callback.
Changeset
Added apiKey to session and keep the apikey in session store.
Testing
Unit tests and scenario test