Rare app crash in shared preferences migrator #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
ghost
force-pushed
the
PLAT-10308_SharedPrefMigrator_can_crash_app
branch
from
5e5c357
to
fe8c946
Compare
lemnik
reviewed
Jun 29, 2023
bugsnag-android-core/src/test/java/com/bugsnag/android/SharedPrefMigratorTest.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/test/java/com/bugsnag/android/SharedPrefMigratorTest.kt
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
PLAT-10308_SharedPrefMigrator_can_crash_app
branch
from
fe8c946
to
f6aa9a0
Compare
ghost
force-pushed
the
PLAT-10308_SharedPrefMigrator_can_crash_app
branch
from
f6aa9a0
to
9c09137
Compare
lemnik
reviewed
Jul 4, 2023
ghost
force-pushed
the
PLAT-10308_SharedPrefMigrator_can_crash_app
branch
from
9c09137
to
8313aaf
Compare
ghost
force-pushed
the
PLAT-10308_SharedPrefMigrator_can_crash_app
branch
from
8313aaf
to
0018c63
Compare
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Prevent rare app crash while migrating old
SharedPreferencesdata from older versions ofbugsnag-android.Changeset
Added nullable check and catching exception for shared preferences
Testing
Additional unit tests