Prevent device data collector may causing a rare app crash while calculating free memory #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
ghost
changed the title
ghost
force-pushed
the
PLAT-10306_NPE_in_DeviceDataCollector
branch
from
a8377c0
to
ed428e6
Compare
lemnik
reviewed
Jul 4, 2023
…the ActivityManager cannot be reached
ghost
force-pushed
the
PLAT-10306_NPE_in_DeviceDataCollector
branch
from
ed428e6
to
3734c5e
Compare
ghost
marked this pull request as ready for review
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Prevent DeviceDataCollector crashing the app when the ActivityManager cannot be reached.
Changeset
Added try and catch for throwable exception.
Testing
Additional unit tests