Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDK should report Array metadata values #1875

Merged
2 commits merged into from Aug 1, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 27, 2023

Goal

NDK Events should report array metadata when it is added in Java / Kotlin.

Changeset

Add array option to OpaqueValue.

Testing

New unit tests introduced.

@ghost ghost requested a review from lemnik July 27, 2023 15:26
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Jul 27, 2023

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1922.55 1696.88
arm64_v8a 680.33 459.15
armeabi_v7a 618.9 393.62
x86 758.14 532.86
x86_64 725.38 504.19

Generated by 🚫 Danger

@lemnik lemnik changed the title OpaqueValue is now supporting arrays NDK should report Array metadata values Jul 27, 2023
@ghost ghost force-pushed the PLAT-10584_User_can_set_array_metadata_for_NDK_events branch from cd0a041 to 8deb7a6 Compare July 28, 2023 09:13
@ghost ghost requested a review from lemnik July 28, 2023 09:13
@ghost ghost force-pushed the PLAT-10584_User_can_set_array_metadata_for_NDK_events branch from 8deb7a6 to ef85ebb Compare July 28, 2023 09:18
@ghost ghost force-pushed the PLAT-10584_User_can_set_array_metadata_for_NDK_events branch from ef85ebb to 253228b Compare July 28, 2023 13:09
@ghost ghost requested a review from lemnik July 28, 2023 13:10
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit a225ea5 into next Aug 1, 2023
28 checks passed
@ghost ghost deleted the PLAT-10584_User_can_set_array_metadata_for_NDK_events branch August 1, 2023 11:13
@ghost ghost mentioned this pull request Aug 8, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants