Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed bugsnag-android-ndk #1881

Merged
1 commit merged into from
Aug 14, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 2, 2023

Goal

Remove deprecated & legacy bugsnag-android-ndk module, as it has been superseded by bugsnag-plugin-android-ndk.

Changeset

Removed bugsnag-android-ndk module and from the project root path.

@ghost ghost requested a review from lemnik August 2, 2023 16:01
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Aug 2, 2023

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1862.18 1697.19
arm64_v8a 622.99 459.15
armeabi_v7a 561.55 393.62
x86 700.79 532.86
x86_64 668.03 500.1

Generated by 🚫 Danger

@lemnik
Copy link
Contributor

lemnik commented Aug 8, 2023

It would be good to get a CHANGELOG entry in here

@ghost ghost force-pushed the PLAT-5795/remove-bugsnag-android-ndk branch 2 times, most recently from 0a69c1f to d6849fb Compare August 9, 2023 08:02
CHANGELOG.md Show resolved Hide resolved
@ghost ghost force-pushed the PLAT-5795/remove-bugsnag-android-ndk branch from d6849fb to 4fdf2f6 Compare August 14, 2023 12:37
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 5f47725 into integration/v6 Aug 14, 2023
24 checks passed
@ghost ghost deleted the PLAT-5795/remove-bugsnag-android-ndk branch August 14, 2023 13:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants