Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process importance in app metadata #1973

Merged
2 commits merged into from
Feb 8, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 6, 2024

Goal

Displayed process improtance in Bugsnag app on dashboard

Changeset

Added processImportance to app metadata

Testing

Introduce new unit test and manual test

@ghost ghost requested a review from lemnik February 6, 2024 02:00
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Feb 6, 2024

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1842.94 1668.27
arm64_v8a 626.95 450.82
armeabi_v7a 561.42 385.29
x86 700.66 524.53
x86_64 671.99 495.86

Generated by 🚫 Danger

@ghost ghost force-pushed the PLAT-11542/capture-process-importance-in-all-events branch from 698d24d to afda1b2 Compare February 6, 2024 09:29
@ghost ghost requested a review from lemnik February 6, 2024 10:23
@ghost ghost force-pushed the PLAT-11542/capture-process-importance-in-all-events branch 2 times, most recently from c27f836 to 792ce71 Compare February 6, 2024 10:32
@ghost ghost force-pushed the PLAT-11542/capture-process-importance-in-all-events branch 2 times, most recently from e0f74b9 to 9c6d561 Compare February 6, 2024 11:20
@ghost ghost force-pushed the PLAT-11542/capture-process-importance-in-all-events branch from 9c6d561 to a541598 Compare February 7, 2024 09:55
@ghost ghost requested a review from lemnik February 7, 2024 09:55
@ghost ghost force-pushed the PLAT-11542/capture-process-importance-in-all-events branch 2 times, most recently from e8da44d to bc7a706 Compare February 7, 2024 11:41
@ghost ghost requested a review from lemnik February 7, 2024 11:49
@ghost ghost force-pushed the PLAT-11542/capture-process-importance-in-all-events branch from bc7a706 to 102b5d5 Compare February 7, 2024 15:07
@ghost ghost requested a review from lemnik February 7, 2024 15:15
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit c833eb7 into next Feb 8, 2024
40 checks passed
@ghost ghost deleted the PLAT-11542/capture-process-importance-in-all-events branch February 8, 2024 08:54
@ghost ghost mentioned this pull request Feb 8, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants