Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: null check for NDK internal metrics (#2012) #2046

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Backport: null check for NDK internal metrics (#2012) #2046

merged 1 commit into from
Jun 27, 2024

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Jun 26, 2024

Goal

Backport the NULL checks in internal_metrics.c to v5

Testing

Relied on existing tests

@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1923.18 1697.22
arm64_v8a 680.33 459.15
armeabi_v7a 618.9 393.62
x86 758.14 532.86
x86_64 725.38 504.19

Generated by 🚫 Danger

YYChen01988
YYChen01988 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@YYChen01988 YYChen01988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemnik lemnik merged commit 4d27e08 into v5/next Jun 27, 2024
20 of 24 checks passed
@lemnik lemnik deleted the PLAT-12359/null-check-backport branch June 27, 2024 08:33
@YYChen01988 YYChen01988 mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

@YYChen01988 YYChen01988 YYChen01988 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lemnik @bugsnagbot @tomlongridge @YYChen01988