Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for setting metadata filters by default #263

Merged
merged 2 commits into from Mar 14, 2018

Conversation

fractalwrench
Copy link
Contributor

MetaData filters are currently left as null unless they are explicitly set. This adds a fix and test coverage to prevent this scenario.

Additionally I've added coverage in 2 Maze Runner scenarios: https://github.com/bugsnag/bugsnag-android/pull/262/files

@coveralls
Copy link

coveralls commented Mar 1, 2018

Pull Request Test Coverage Report for Build 1179

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • 19 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.3%) to 71.067%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdk/src/main/java/com/bugsnag/android/Configuration.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
sdk/src/main/java/com/bugsnag/android/MetaData.java 1 93.0%
sdk/src/main/java/com/bugsnag/android/DeviceData.java 2 77.44%
sdk/src/main/java/com/bugsnag/android/Client.java 3 53.71%
sdk/src/main/java/com/bugsnag/android/SessionTracker.java 13 54.62%
Totals Coverage Status
Change from base Build 1155: 0.3%
Covered Lines: 1771
Relevant Lines: 2492

💛 - Coveralls

@snmaynard
Copy link
Contributor

Why not just set the default in the metadata class?

@fractalwrench
Copy link
Contributor Author

You're right, that's a much better way of doing it - I've updated the PR.

@fractalwrench fractalwrench merged commit 0c09dd2 into master Mar 14, 2018
@fractalwrench fractalwrench deleted the fix-metadata-filters branch March 14, 2018 15:39
lemnik pushed a commit that referenced this pull request Jun 2, 2021
Respect bugsnag.enabled flag when registering tasks
rich-bugsnag pushed a commit that referenced this pull request Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants