Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional multi client scenarios #289

Merged
merged 2 commits into from Apr 18, 2018

Conversation

fractalwrench
Copy link
Contributor

Adds the following scenarios when multiple clients are initialised:

  • Calling notify while offline is only sent to original client
  • Unhandled error while offline is sent twice with different API key for each
  • Unhandled error while online is sent twice with different API key for each
  • Unhandled error while offline is sent twice with different endpoint for each
  • Cached sessions with different API keys are only sent to original client

This also includes a minor change to the TestHarnessHooks which is required to flush the sessions on a per-client basis

Relies on #286

- Cached unhandled errors with different API keys
- Cached unhandled errors with different endpoints
- Cached sessions
@fractalwrench fractalwrench requested a review from a team April 18, 2018 13:17
@coveralls
Copy link

coveralls commented Apr 18, 2018

Pull Request Test Coverage Report for Build 1304

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.5%) to 74.052%

Files with Coverage Reduction New Missed Lines %
sdk/src/main/java/com/bugsnag/android/Client.java 3 58.74%
sdk/src/main/java/com/bugsnag/android/DeviceData.java 3 76.69%
sdk/src/main/java/com/bugsnag/android/SessionTracker.java 13 57.89%
Totals Coverage Status
Change from base Build 1301: 0.5%
Covered Lines: 1855
Relevant Lines: 2505

💛 - Coveralls

@kattrali kattrali merged commit 52c06f6 into multi-client-scenario Apr 18, 2018
@kattrali kattrali deleted the additional-multi-client-scenarios branch April 18, 2018 21:35
lemnik pushed a commit that referenced this pull request Jun 2, 2021
Revert "Avoid creating debug tasks unless uploadDebugBuildMappings flag enabled"
rich-bugsnag added a commit that referenced this pull request Sep 3, 2021
fix (Unity 2021 builds): adapt post process build script to work with unity 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants