refactor: fail build on compiler warnings

sdk/build.gradle

@@ -37,6 +37,12 @@ android {
     }
 }
 
+gradle.projectsEvaluated {
+    tasks.withType(JavaCompile) {
+        options.compilerArgs << "-Xlint:all" << "-Werror"
+    }
+}
+
 coveralls {
     jacocoReportPath = "$buildDir/reports/coverage/debug/report.xml"
 }

sdk/src/androidTest/java/com/bugsnag/android/BugsnagTestUtils.java

@@ -70,6 +70,7 @@ static SessionStore generateSessionStore() {
         return new SessionStore(generateConfiguration(), InstrumentationRegistry.getContext());
     }
 
+    @SuppressWarnings("deprecation")
     @NonNull
     static SessionTrackingApiClient generateSessionTrackingApiClient() {
         return new SessionTrackingApiClient() {
@@ -83,6 +84,7 @@ public void postSessionTrackingPayload(String urlString,
         };
     }
 
+    @SuppressWarnings("deprecation")
     static ErrorReportApiClient generateErrorReportApiClient() { // no-op
         return new ErrorReportApiClient() {
             @Override

sdk/src/androidTest/java/com/bugsnag/android/ClientConfigTest.java

@@ -63,6 +63,7 @@ public void testSetContext() throws Exception {
         assertEquals("JunitTest", config.getContext());
     }
 
+    @SuppressWarnings("deprecation")
     @Test
     public void testSetEndpoint() throws Exception {
         client.setEndpoint("http://example.com/bugsnag");

sdk/src/androidTest/java/com/bugsnag/android/ClientNotifyTest.java

@@ -26,6 +26,7 @@ public class ClientNotifyTest {
      *
      * @throws Exception if initialisation failed
      */
+    @SuppressWarnings("deprecation")
     @Before
     public void setUp() throws Exception {
         client = BugsnagTestUtils.generateClient();
@@ -81,6 +82,7 @@ public void beforeNotify(Report report) {
         assertEquals("Message", error.getExceptionMessage());
     }
 
+    @SuppressWarnings("deprecation")
     static class FakeClient implements ErrorReportApiClient {
 
         CountDownLatch latch = new CountDownLatch(1);

sdk/src/androidTest/java/com/bugsnag/android/ClientTest.java

@@ -90,6 +90,7 @@ public void testNotify() {
         client.notify(new RuntimeException("Testing"));
     }
 
+    @SuppressWarnings("deprecation")
     @Test
     public void testConfig() {
         config.setEndpoint("new-endpoint");
@@ -107,9 +108,8 @@ public void testRestoreUserFromPrefs() {
         setUserPrefs();
 
         config.setPersistUserBetweenSessions(true);
+        config.setDelivery(BugsnagTestUtils.generateDelivery());
         Client client = new Client(context, config);
-        client.setErrorReportApiClient(BugsnagTestUtils.generateErrorReportApiClient());
-        client.setSessionTrackingApiClient(BugsnagTestUtils.generateSessionTrackingApiClient());
 
         final User user = new User();
 
@@ -269,6 +269,7 @@ public void testClientClearTab() {
         assertTrue(client.getMetaData().getTab("drink").isEmpty());
     }
 
+    @SuppressWarnings("deprecation")
     @Test(expected = IllegalArgumentException.class)
     public void testApiClientNullValidation() {
         generateClient().setSessionTrackingApiClient(null);

sdk/src/androidTest/java/com/bugsnag/android/ConfigurationTest.java

@@ -71,6 +71,7 @@ public void testAutoCaptureOverride() {
         assertFalse(config.shouldAutoCaptureSessions());
     }
 
+    @SuppressWarnings("deprecation")
     @Test
     public void testEndpoint() {
         // Default endpoints
@@ -82,6 +83,7 @@ public void testEndpoint() {
         assertEquals(endpoint, config.getEndpoint());
     }
 
+    @SuppressWarnings("deprecation")
     @Test
     public void testSessionEndpoint() {
         // Default endpoints

sdk/src/androidTest/java/com/bugsnag/android/CustomException.java

@@ -6,6 +6,8 @@
 
 class CustomException extends Exception implements JsonStream.Streamable {
 
+    private static final long serialVersionUID = 1962801050513549513L;
+
     CustomException(String message) {
         super(message);
     }

sdk/src/androidTest/java/com/bugsnag/android/DeliveryCompatTest.java

@@ -35,6 +35,7 @@ public void tearDown() throws Exception {
         Async.cancelTasks();
     }
 
+    @SuppressWarnings("deprecation")
     @Test
     public void deliverReport() throws Exception {
         Report report = null;
@@ -54,6 +55,7 @@ public void postReport(String urlString,
         assertEquals(1, customCount.get());
     }
 
+    @SuppressWarnings("deprecation")
     @Test
     public void deliverSession() throws Exception {
         SessionTrackingPayload payload = null;
@@ -73,6 +75,7 @@ public void postSessionTrackingPayload(String urlString,
         assertEquals(1, customCount.get());
     }
 
+    @SuppressWarnings("deprecation")
     @Test
     public void testClientCompat() {
         Client client = BugsnagTestUtils.generateClient();
@@ -96,11 +99,13 @@ public void testClientCompat() {
         assertEquals(sessionClient, compat.sessionTrackingApiClient);
     }
 
+    @SuppressWarnings("deprecation")
     @Test(expected = DeliveryFailureException.class)
     public void testExceptionConversion() throws Exception {
         deliveryCompat.handleException(new NetworkException("", null));
     }
 
+    @SuppressWarnings("deprecation")
     @Test
     public void testSwallowExceptionConversion() throws Exception { // no exception thrown
         deliveryCompat.handleException(new BadResponseException("", 0));

sdk/src/androidTest/java/com/bugsnag/android/ErrorReportApiClientTest.java

@@ -31,11 +31,13 @@ public void tearDown() throws Exception {
         Async.cancelTasks();
     }
 
+    @SuppressWarnings("deprecation")
     @Test(expected = IllegalArgumentException.class)
     public void testApiClientNullValidation() {
         Bugsnag.setErrorReportApiClient(null);
     }
 
+    @SuppressWarnings("deprecation")
     @Test
     public void testPostReportCalled() {
         Bugsnag.setErrorReportApiClient(apiClient);
@@ -46,6 +48,7 @@ public void testPostReportCalled() {
         assertNotNull(apiClient.report);
     }
 
+    @SuppressWarnings("deprecation")
     private static class FakeApiClient implements ErrorReportApiClient {
         private Report report;
 

sdk/src/androidTest/java/com/bugsnag/android/MetaDataTest.java

@@ -167,6 +167,8 @@ public void testDeepMerge() {
 
         MetaData merged = MetaData.merge(base, overrides);
         Map<String, Object> tab = merged.getTab("example");
+
+        @SuppressWarnings("unchecked")
         Map<String, String> mergedMap = (Map<String, String>) tab.get("map");
         assertEquals("fromOverrides", mergedMap.get("key"));
     }

sdk/src/androidTest/java/com/bugsnag/android/NullMetadataTest.java

@@ -31,17 +31,7 @@ public class NullMetadataTest {
     @Before
     public void setUp() throws Exception {
         config = new Configuration("api-key");
-        Bugsnag.init(InstrumentationRegistry.getContext(), config);
-        Bugsnag.setErrorReportApiClient(new ErrorReportApiClient() {
-            @Override
-            public void postReport(String urlString,
-                                   Report report,
-                                   Map<String, String> headers)
-                throws NetworkException, BadResponseException {
-
-            }
-        });
-
+        BugsnagTestUtils.generateClient();
         throwable = new RuntimeException("Test");
     }
 

sdk/src/androidTest/java/com/bugsnag/android/ReportTest.java

@@ -51,6 +51,7 @@ public void testModifyingGroupingHash() throws JSONException, IOException {
         assertEquals(groupingHash, event.getString("groupingHash"));
     }
 
+    @SuppressWarnings("deprecation")
     @Test
     public void testModifyReportDetails() throws Exception {
         String apiKey = "custom-api-key";

sdk/src/main/java/com/bugsnag/android/BadResponseException.java

@@ -7,6 +7,8 @@
  */
 @Deprecated
 public class BadResponseException extends Exception {
+    private static final long serialVersionUID = -870190454845379171L;
+
     public BadResponseException(String msg, int responseCode) {
         super(String.format(Locale.US, "%s (%d)", msg, responseCode));
     }

sdk/src/main/java/com/bugsnag/android/Bugsnag.java

@@ -425,6 +425,7 @@ public static void notify(@NonNull final Throwable exception, final Severity sev
      * @param metaData  additional information to send with the exception
      * @deprecated Use {@link #notify(Throwable, Callback)} to send and modify error reports
      */
+    @Deprecated
     public static void notify(@NonNull final Throwable exception,
                               @NonNull final MetaData metaData) {
         getClient().notify(exception, new Callback() {

sdk/src/main/java/com/bugsnag/android/BugsnagException.java

@@ -5,6 +5,7 @@
  */
 public class BugsnagException extends Throwable {
 
+    private static final long serialVersionUID = 5068182621179433346L;
     /**
      * The name of the exception (used instead of the exception class)
      */

sdk/src/main/java/com/bugsnag/android/Client.java

@@ -822,6 +822,7 @@ public void notify(@NonNull Throwable exception, Severity severity) {
      * @param metaData  additional information to send with the exception
      * @deprecated Use {@link #notify(Throwable, Callback)} to send and modify error reports
      */
+    @Deprecated
     public void notify(@NonNull Throwable exception,
                        @NonNull MetaData metaData) {
         Error error = new Error.Builder(config, exception, sessionTracker.getCurrentSession())
@@ -1051,6 +1052,7 @@ public void notifyBlocking(@NonNull String name,
      * @param metaData  additional information to send with the exception
      * @deprecated Use {@link #notify(Throwable, Callback)} to send and modify error reports
      */
+    @Deprecated
     public void notifyBlocking(@NonNull Throwable exception,
                                @NonNull MetaData metaData) {
         Error error = new Error.Builder(config, exception, sessionTracker.getCurrentSession())

sdk/src/main/java/com/bugsnag/android/DeliveryCompat.java

@@ -7,7 +7,10 @@
  */
 class DeliveryCompat implements Delivery {
 
+    // ignore deprecation of legacy clients
+    @SuppressWarnings("deprecation")
     volatile ErrorReportApiClient errorReportApiClient;
+    @SuppressWarnings("deprecation")
     volatile SessionTrackingApiClient sessionTrackingApiClient;
 
     @Override
@@ -35,6 +38,7 @@ public void deliver(Report report, Configuration config) throws DeliveryFailureE
         }
     }
 
+    @SuppressWarnings("deprecation") // ignore networkexception deprecation
     void handleException(Throwable throwable) throws DeliveryFailureException {
         if (throwable instanceof NetworkException) {
             throw new DeliveryFailureException(throwable.getMessage(), throwable);

sdk/src/main/java/com/bugsnag/android/DeliveryFailureException.java

@@ -7,6 +7,8 @@
  * @see Delivery
  */
 public class DeliveryFailureException extends Exception {
+    private static final long serialVersionUID = 1501477209400426470L;
+
     public DeliveryFailureException(String message) {
         super(message);
     }

sdk/src/main/java/com/bugsnag/android/DeviceData.java

@@ -246,6 +246,7 @@ private String[] getCpuAbi() {
      * Get the free disk space on the smallest disk
      */
     @Nullable
+    @SuppressWarnings("deprecation") // ignore blockSizeLong suggestions for now (requires API 18)
     private Long calculateFreeDisk() {
         try {
             StatFs externalStat = new StatFs(Environment.getExternalStorageDirectory().getPath());
@@ -336,6 +337,7 @@ private Boolean isCharging() {
      * Get the current status of location services
      */
     @Nullable
+    @SuppressWarnings("deprecation") // LOCATION_PROVIDERS_ALLOWED is deprecated
     private String getLocationStatus() {
         try {
             ContentResolver cr = appContext.getContentResolver();
@@ -404,6 +406,7 @@ static String[] getSupportedAbis() {
      */
     static class Abi2Wrapper {
         @NonNull
+        @SuppressWarnings("deprecation") // new API already used elsewhere
         static String[] getAbi1andAbi2() {
             return new String[]{Build.CPU_ABI, Build.CPU_ABI2};
         }

sdk/src/main/java/com/bugsnag/android/JsonWriter.java

@@ -197,7 +197,7 @@ enum JsonScope {
     static {
         REPLACEMENT_CHARS = new String[128];
         for (int i = 0; i <= 0x1f; i++) {
-            REPLACEMENT_CHARS[i] = String.format("\\u%04x", (int) i);
+            REPLACEMENT_CHARS[i] = String.format("\\u%04x", i);
         }
         REPLACEMENT_CHARS['"'] = "\\\"";
         REPLACEMENT_CHARS['\\'] = "\\\\";

sdk/src/main/java/com/bugsnag/android/MetaData.java

@@ -101,6 +101,7 @@ public void clearTab(String tabName) {
 
     @NonNull
     Map<String, Object> getTab(String tabName) {
+        @SuppressWarnings("unchecked")
         Map<String, Object> tab = (Map<String, Object>) store.get(tabName);
 
         if (tab == null) {
@@ -135,12 +136,14 @@ static MetaData merge(@NonNull MetaData... metaDataList) {
             }
         }
 
+        @SuppressWarnings({"unchecked", "rawtypes"})
         MetaData newMeta = new MetaData(mergeMaps(stores.toArray(new Map[0])));
         newMeta.setFilters(filters.toArray(new String[filters.size()]));
 
         return newMeta;
     }
 
+    @SafeVarargs
     @NonNull
     private static Map<String, Object> mergeMaps(@NonNull Map<String, Object>... maps) {
         Map<String, Object> result = new ConcurrentHashMap<>();
@@ -163,8 +166,11 @@ private static Map<String, Object> mergeMaps(@NonNull Map<String, Object>... map
                         && baseValue instanceof Map
                         && overridesValue instanceof Map) {
                         // Both original and overrides are Maps, go deeper
-                        result.put(key, mergeMaps((Map<String, Object>) baseValue,
-                            (Map<String, Object>) overridesValue));
+                        @SuppressWarnings("unchecked")
+                        Map<String, Object> first = (Map<String, Object>) baseValue;
+                        @SuppressWarnings("unchecked")
+                        Map<String, Object> second = (Map<String, Object>) overridesValue;
+                        result.put(key, mergeMaps(first, second));
                     } else {
                         result.put(key, overridesValue);
                     }

sdk/src/main/java/com/bugsnag/android/NativeInterface.java

@@ -45,7 +45,7 @@ public static void configureClientObservers(@NonNull Client client) {
         // Should only happen if the NDK library is present
         try {
             String className = "com.bugsnag.android.ndk.BugsnagObserver";
-            Class clz = Class.forName(className);
+            Class<?> clz = Class.forName(className);
             Observer observer = (Observer) clz.newInstance();
             client.addObserver(observer);
         } catch (ClassNotFoundException exception) {
@@ -256,11 +256,10 @@ public void beforeNotify(@NonNull Report report) {
                 error.config.defaultExceptionType = "c";
 
                 for (String tab : metaData.keySet()) {
-
                     Object value = metaData.get(tab);
 
                     if (value instanceof Map) {
-                        Map map = (Map) value;
+                        @SuppressWarnings("unchecked") Map<Object, Object> map = (Map) value;
 
                         for (Object key : map.keySet()) {
                             error.getMetaData().addToTab(tab, key.toString(), map.get(key));

sdk/src/main/java/com/bugsnag/android/NetworkException.java

@@ -7,6 +7,8 @@
  */
 @Deprecated
 public class NetworkException extends IOException {
+    private static final long serialVersionUID = -4370366096145029322L;
+
     public NetworkException(String msg, Throwable cause) {
         super(msg, cause);
     }

sdk/src/main/java/com/bugsnag/android/ObjectJsonStreamer.java

@@ -30,7 +30,10 @@ void objectToStream(@Nullable Object obj,
             // Map objects
             writer.beginObject();
             for (Object o : ((Map) obj).entrySet()) {
-                Map.Entry entry = (Map.Entry) o;
+
+                @SuppressWarnings("unchecked")
+                Map.Entry<Object, Object> entry = (Map.Entry<Object, Object>) o;
+
                 Object keyObj = entry.getKey();
                 if (keyObj instanceof String) {
                     String key = (String) keyObj;