Add ThreadSafe annotation to com.bugsnag.android, remove infer dependency

[fractalwrench]

Goal

Removes the need for a compile-time dependency on the infer-annotation artefact.

Changeset

• Added @ThreadSafe annotation to bugsnag package
• Removed imports of infer-annotation
• Altered build process so that the infer property must be set to compile infer-annotation artefact

Tests

• Ran ./infer.sh
• Ran ./gradlew sdk:assemble to confirm
• Ran generatePomFileForProductionPublication task to confirm that the generated POM excludes the infer-annotation dependency.
• Ran existing unit/mazerunner tests on CI

Discussion

Alternative Approaches

We could attempt forking Uber's infer plugin, which is deprecated.

Linked issues

Fixes #366

Review

For the submitter, initial self-review:

• Commented on code changes inline explain the reasoning behind the approach
• Reviewed the test cases added for completeness and possible points for discussion
• A changelog entry was added for the goal of this pull request
• Check the scope of the changeset - is everything in the diff required for the pull request?
• This pull request is ready for:
  • Initial review of the intended approach, not yet feature complete
  • Structural review of the classes, functions, and properties modified
  • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

• Consistency across platforms for structures or concepts added or modified
• Consistency between the changeset and the goal stated above
• Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
• Usage friction - is the proposed change in usage cumbersome or complicated?
• Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
• Concurrency concerns - if components are accessed asynchronously, what issues will arise
• Thoroughness of added tests and any missing edge cases
• Idiomatic use of the language

[fractalwrench]

adds com.bugsnag.android.ThreadSafe as an alias for com.facebook.infer.annotation.ThreadSafe

[kattrali]

Seems pretty magical (in a good way). Shouldn't there be something in the contrib guide about how to run this and what its for?

[kattrali]

This should also link the fixed issue.

resolved

[coveralls]

Coverage remained the same at 68.545% when pulling 7c1910f on update-infer-setup into b70c558 on master.