Fix bintray gradle plugin failure, update release steps gradle task #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te correct task for publishing The bintray gradle plugin was updated for compatibility with gradle 4.8, but we did not update when we last updated the gradle wrapper, which broke the upload of artifacts to bintray. The release steps have also been updated to state the appropriate task for uploading to sonatype.
kattrali
reviewed
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bintray gradle plugin was updated for compatibility with gradle 4.8, but we did not update when we last updated the gradle wrapper. This broke the upload of artefacts to bintray when running
./gradlew bintrayUpload- updating the plugin resolves this issue.Additionally, the task for uploading artefacts to sonatype specified in the release steps has been wrong since the NDK integration was altered - the correct task is now specified in the release steps.