Update Android Gradle Plugin to v3.2.1 #388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Update the AGP to v3.2+, to enable the
SyntheticAccessor
lint check. Synthetic accessors are generated when an inner class accesses a private method or field in its enclosing class, for example:Changeset
kotlin-stdlib
dependency, as the deprecatedkotlin-stdlib-jre
artefact is not available in 1.3.10UnknownNullness
andKotlinPropertyAccess
.SyntheticAccessor
lint check to package-private, which removes 8 unnecessary methods 🎉Tests
Ran existing test suites on CI
Discussion
Internal tickets have been created for addressing the pre-existing
KotlinPropertyAccess
andUnknownNullness
checks in a separate PR.