feat: Add C++ exception handler #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
force-pushed
the
kattrali/cpp-handler
branch
2 times, most recently
from
5e1f9dd
to
9e41b69
Compare
bullmo
reviewed
Jan 17, 2019
kattrali
force-pushed
the
kattrali/cpp-handler
branch
from
9e41b69
to
bcb448d
Compare
Handles C++ exceptions in the std::set_terminate function rather than waiting for the exception to propagate to the signal handler. Improves the quality of stacktraces by working around issues in abort(), adds the C++ exception type name as the error class and a description of the thrown object as the message.
For the C++ handler in particular, once handling is complete, it uninstalls itself and calls the previous handler. The default previous handler abort()s the app which would then trigger the signal handler. This introduces a check whether handling is completed and if so, calls the default/previous signal handler, terminating the application cleanly.
kattrali
force-pushed
the
kattrali/cpp-handler
branch
2 times, most recently
from
dc3fd25
to
bb1a2a6
Compare
fractalwrench
approved these changes
Jan 22, 2019
| * | ||
| * References: | ||
| * * https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/set-terminate-crt | ||
| */ |
There was a problem hiding this comment.
These are great docs 👍
When capturing a stacktrace from a signal handler or C++ terminate handler different unwinders deadlock on different architectures and/or Android API levels. This change uses different unwinders based on whether async signal safety is required or not, by supported API levels. It introduces libunwindstack as the signal-safe unwinder for API 15+ on ARM64 and x86/x64 devices. For notify()/C++ exceptions, use libunwind, nongnu libunwind, or libcorkscrew depending on the API level. * libcorkscrew hangs when unwinding from a C++ exception on ARM 32-bit. * libunwind hangs on ARM64 from a signal handler * nongnu libunwind hangs on ARM32 from a signal handler if raise() is called directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles C++ exceptions in the std::set_terminate function rather than
waiting for the exception to propagate to the signal handler. Improves
the quality of stacktraces by working around issues in abort(), adds the
C++ exception type name as the error class and a description of the
thrown object as the message.
Design
Added a new handler alongside the signal handler to catch C++ exceptions earlier.
std::exceptioninstances, this is the message.Tests
Added new end-to-end tests for handling throwing a C++ exception and throwing a random thing. Checks that the report is valid, the stacktrace is reasonable, and the error class and message match.