Reduce sensitivity of Foreground Detection, reducing potential ANR false positives #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When detecting whether the application is in the foreground, we should use IMPORTANCE_FOREGROUND_SERVICE rather than IMPORTANCE_VISIBLE. We have observed false positives in ANRs for some specific device manufacturers and tightening the threshold for what is considered the foreground may reduce the signal-noise ratio.
bengourley
approved these changes
May 17, 2019
There was a problem hiding this comment.
Looks good.
One related question: could it be that we are getting false positives from this logic too?
In the unlikely event that information about the process cannot be retrieved, this method will return true. This is deemed preferable as ANRs are only reported when the application is in the foreground, and we would rather deliver false-positives than miss true ANRs in this case
?
fractalwrench
force-pushed
the
tweak-foreground-detection
branch
from
59ee381
to
1060210
Compare
|
Thanks @bengourley - I've updated that method to return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
When detecting whether the application is in the foreground, we should try using
IMPORTANCE_FOREGROUND_SERVICErather thanIMPORTANCE_VISIBLE. We have observed false positives in ANRs for some specific device manufacturers and tightening the threshold for what is considered the foreground may reduce the signal-noise ratio.Tests
Ran ANR mazerunner scenarios locally.