Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: address flaky unit tests found on browserstack #483

Merged
merged 3 commits into from May 16, 2019

Conversation

fractalwrench
Copy link
Contributor

Goal

Fixes some of the flaky unit tests found on browserstack.

Changeset

  • Initialise breadcrumbs test with automatic capture of breadcrumbs disabled
  • Use a client rather than Bugsnag in the null metadata test to prevent Bugsnag.init crashing app
  • Tentative fix for Travis CI hanging (I believe BeforeSendSessionTest will hang forever due to the session tracker rejecting execution)

Copy link
Contributor

@Cawllec Cawllec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending travis Unit tests

@fractalwrench fractalwrench merged commit 2674dfd into master May 16, 2019
@fractalwrench fractalwrench deleted the unit-test-fix branch May 16, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants