fix(ndk): Skip null metadata values from serialization #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
force-pushed
the
kattrali/fix-empty-metadata-bug
branch
from
2742e52
to
265efaa
Compare
fractalwrench
suggested changes
Jul 2, 2019
In the event that a metadata value is null, the patched section would crash in GetStringUTFChars(). This is most easily reproduced by calling notify/throwing on an exception with no message.
kattrali
force-pushed
the
kattrali/fix-empty-metadata-bug
branch
from
265efaa
to
2f270bc
Compare
fractalwrench
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that a metadata value is null, the patched section would
crash in
GetStringUTFChars(). This is most easily reproduced by callingnotify/throwing on an exception with no message.
Tests
leaveErrorBreadcrumb()which would then be serialized by the native layer.