-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report internal errors when serialization fails #581
Conversation
Buffer io when reading from cached error file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few concerns inline though my biggest right now is how can this change be verified? Is it tested in some way already?
bugsnag-android-core/src/main/java/com/bugsnag/android/Client.java
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/Client.java
Outdated
Show resolved
Hide resolved
I originally tested this by assembling a local artefact, altering the relevant code to always throw an exception, then checking on a local server that the payload was correct. I've also tested against our internal instance and verified the exceptions are picked up. This doesn't seem like the sort of change that would be feasible to test in an automated way - at least, I can't think of a good way to achieve that. |
Goal
#570 added internal error reports for deserialization, which are delivered to Bugsnag when an unanticipated error occurred. This adds similar functionality for the serialization case, which will allow us to diagnose errors when writing files.
Changeset
delegate
property toFileStore
so that serialisation errors are captured for errors/session payloads