Delete empty files left in cache directory #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API 26 added a cacheBehaviorTombstone API, which leaves behind a zero-length file rather than deleting the file entirely. We should delete these files when attempting to send cached errors/sessions.
kattrali
reviewed
Sep 10, 2019
bugsnag-android-core/src/main/java/com/bugsnag/android/FileStore.java
Outdated
Show resolved
Hide resolved
|
I've now added a mazerunner scenario to verify that cached tombstone files are deleted. |
fractalwrench
force-pushed
the
delete-tombstones
branch
from
8f5ae6d
to
1a5829f
Compare
fractalwrench
force-pushed
the
delete-tombstones
branch
from
1a5829f
to
14ba762
Compare
fractalwrench
changed the title
tomlongridge
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
API 26 added a cacheBehaviorTombstone API, which leaves behind a zero-length file rather than
deleting the file entirely. We should delete any empty files when attempting to send cached
errors/sessions.
Changeset
Check for the presence of an empty file and delete it within
findStoredFiles().Tests
Manually verified in a local artefact that if an empty file is added to the
bugsnag-errorsdirectory it is discarded.