Prevent internal error reporting of FileNotFoundException during Delivery #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen delivering error reports FileNotFoundException can occur due to a race where the oldest file is deleted from disk, and the Error object sends a cached file directly in the request. If this does occur, we should suppress internal error reports as it is a known issue that we cannot handle.
bugsnag-android-core/src/main/java/com/bugsnag/android/ErrorStore.java
Outdated
Show resolved
Hide resolved
|
Thanks for taking a look @tomlongridge - I've logged a warning in a separate catch block as requested. |
tomlongridge
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
FileNotFoundExceptioncan occur due to a race where the oldest file is deleted from disk, and theErrorobject sends a cached file directly in the request. If this does occur, we should suppressinternal error reports as it is a known issue that we cannot handle.
Design
It is worth noting that redesigning the
ErrorStoreso that theFileis always deserialized into anErrorobject would prevent this scenario from occurring.However, given the complexity of these changes and incidence of this situation, it was seen as more appropriate to avoid sending an internal error report instead.