Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-4713] RN: Retain unhandled value when parsing a JS event #914

Merged
merged 1 commit into from Jul 31, 2020
Merged

[PLAT-4713] RN: Retain unhandled value when parsing a JS event #914

merged 1 commit into from Jul 31, 2020

Conversation

bengourley
Copy link
Contributor

When the severity is modified in a JS onError callback, the original value for unhandled was lost. This update takes and applies the unhandled value from the JS event payload.

twometresteve
twometresteve approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bengourley bengourley merged commit f421b45 into master Jul 31, 2020
@bengourley bengourley deleted the bengourley/rn-unhandled-flag-fix branch July 31, 2020 16:01
@bengourley bengourley mentioned this pull request Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twometresteve twometresteve twometresteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bengourley @twometresteve