Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plat-10076] Disable viewWillDisappear swizzling #124

Merged
merged 2 commits into from May 3, 2023

Conversation

kstenerud
Copy link
Contributor

Goal

Disable swizzling of viewWillDisappear for now until a better solution can be built.

The swizzle code could cause crashes in some multithreaded situations.

@github-actions
Copy link

github-actions bot commented May 2, 2023

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  +2.5%    +296    [__LINKEDIT]
  +0.6%    +247  +0.6%    +247    [__TEXT]
  +0.1%      +8  +0.1%      +8    [__DATA]
  -0.4%      -8  -0.4%      -8    __DATA,__objc_selrefs
  -0.4%     -12  -0.4%     -12    __TEXT,__unwind_info
  -0.2%     -16  -0.2%     -16    __TEXT,__gcc_except_tab
  -0.2%     -19  -0.2%     -19    __TEXT,__objc_methname
  -0.2%    -112  -0.2%    -112    Symbol Table
  -0.2%    -184  -0.2%    -184    String Table
  -0.3%    -200  -0.3%    -200    __TEXT,__text
  -0.1%    -296  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud force-pushed the PLAT-10076-disable-view-will-disappear branch from c1b3fa5 to 05075fb Compare May 2, 2023 14:19
@kstenerud kstenerud merged commit 942a5ee into next May 3, 2023
16 checks passed
@kstenerud kstenerud deleted the PLAT-10076-disable-view-will-disappear branch May 3, 2023 07:11
@kstenerud kstenerud mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants