Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-10051] Don't capture file:// URLRequests #138

Merged
merged 1 commit into from May 11, 2023

Conversation

kstenerud
Copy link
Contributor

Goal

We don't want to capture URLRequests that were actually for local files. We only want to capture network requests.

Design

Check the URL scheme and ignore any that are file.

Testing

Added extra e2e test to verify this.

@github-actions
Copy link

github-actions bot commented May 11, 2023

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2%    +136  +0.2%    +136    __TEXT,__text
  +0.0%     +32  +0.0%     +32    String Table
  +0.5%     +32  +0.5%     +32    __DATA,__cfstring
  +0.4%     +32  +0.4%     +32    __TEXT,__objc_stubs
  +0.4%     +28  +0.4%     +28    __TEXT,__gcc_except_tab
  +0.0%     +16  +0.0%     +16    Symbol Table
  +0.2%     +15  +0.2%     +15    __TEXT,__objc_methname
  +0.4%      +8  +0.4%      +8    __DATA,__objc_selrefs
  +0.1%      +5  +0.1%      +5    __TEXT,__cstring
  -0.5%     -40  -0.5%     -40    [__DATA]
  [ = ]       0  -0.3%     -48    [__LINKEDIT]
  -0.7%    -216  -0.7%    -216    [__TEXT]
  +0.0%     +48  [ = ]       0    TOTAL

Generated by 🚫 Danger

Copy link
Contributor

@tomlongridge tomlongridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pending changelog entry

Copy link

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Pending CI

@kstenerud kstenerud merged commit 88d46fb into next May 11, 2023
16 checks passed
@kstenerud kstenerud deleted the PLAT-10051-file-urlrequest branch May 11, 2023 12:09
@kstenerud kstenerud mentioned this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants