[PLAT-10049] Added view_load_phase spans #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
kstenerud
reviewed
May 19, 2023
|
|
||
| controller = [MyTestViewController new]; | ||
| [controller loadView]; | ||
| [controller viewDidLoad]; | ||
| XCTAssertEqual(1U, perf->testing_getBatchCount()); | ||
| XCTAssertEqual(6U, perf->testing_getBatchCount()); | ||
| // Temporarily disabled to stop crashes while we build a more complete solution |
There was a problem hiding this comment.
Oh could you uncomment these 2 disabled lines again? I forgot to do it after the refactor.
|
|
||
| selector = @selector(viewWillLayoutSubviews); | ||
| IMP viewWillLayoutSubviews __block = nullptr; | ||
| viewWillLayoutSubviews = ObjCSwizzle::replaceInstanceMethodOverride(cls, selector, ^(id self, BOOL animated){ |
There was a problem hiding this comment.
viewWillLayoutSubviews is type void, so it won't have BOOL animated.
| Trace(@"%@ -[%s %s]", self, class_getName(cls), sel_getName(selector)); | ||
| } | ||
| BugsnagPerformanceSpan *span = startViewLoadPhaseSpan(self, @"viewWillLayoutSubviews"); | ||
| reinterpret_cast<void (*)(id, SEL, BOOL)>(viewWillLayoutSubviews)(self, selector, animated); |
There was a problem hiding this comment.
This will be reinterpret_cast<void (*)(id, SEL)>
|
|
||
| selector = @selector(viewDidLayoutSubviews); | ||
| IMP viewDidLayoutSubviews __block = nullptr; | ||
| viewDidLayoutSubviews = ObjCSwizzle::replaceInstanceMethodOverride(cls, selector, ^(id self, BOOL animated){ |
There was a problem hiding this comment.
Similar here:viewDidLayoutSubviews is a void method.
|
|
||
| selector = @selector(viewWillAppear:); | ||
| IMP viewWillAppear __block = nullptr; | ||
| viewWillAppear = ObjCSwizzle::replaceInstanceMethodOverride(cls, selector, ^(id self){ |
There was a problem hiding this comment.
viewWillAppear takes a BOOL parameter, so this must be ^(id self, BOOL animated)
| Trace(@"%@ -[%s %s]", self, class_getName(cls), sel_getName(selector)); | ||
| } | ||
| BugsnagPerformanceSpan *span = startViewLoadPhaseSpan(self, @"viewWillAppear"); | ||
| reinterpret_cast<void (*)(id, SEL)>(viewWillAppear)(self, selector); |
There was a problem hiding this comment.
This must be reinterpret_cast<void (*)(id, SEL, BOOL)>
kstenerud
approved these changes
May 22, 2023
added 5 commits
May 23, 2023 10:22
# Conflicts: # features/automatic_spans.feature
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.