Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-10195] Add subseconds to iso8601 dates even on ios 11 #159

Merged
merged 1 commit into from May 31, 2023

Conversation

kstenerud
Copy link
Contributor

Goal

iOS 11.2 and below don't support subseconds in the ISO 8601 date formatter.

This PR compensates for that.

Testing

Manually tested on an ios 11.0 device to ensure the e2e tests still pass.

@kstenerud kstenerud changed the title Add subseconds to iso8601 dates even on ios 11 [PLAT-10195] Add subseconds to iso8601 dates even on ios 11 May 31, 2023
@github-actions
Copy link

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.4%    +328  +0.4%    +328    __TEXT,__text
  +0.1%    +152  +0.1%    +152    String Table
  +1.7%    +128  +1.7%    +128    __TEXT,__objc_stubs
  +0.1%     +80  +0.1%     +80    Symbol Table
  +0.8%     +67  +0.8%     +67    __TEXT,__objc_methname
  +1.0%     +64  +1.0%     +64    __DATA,__cfstring
  +0.6%     +44  +0.6%     +44    __TEXT,__gcc_except_tab
  +1.3%     +40  +1.3%     +40    Binding Info
  +1.6%     +32  +1.6%     +32    __DATA,__objc_selrefs
  +0.3%     +13  +0.3%     +13    __TEXT,__cstring
  +2.1%      +8  +2.1%      +8    __DATA,__objc_classrefs
  -1.2%    -104  -1.2%    -104    [__DATA]
  [ = ]       0  -6.0%    -272    [__LINKEDIT]
  -1.4%    -580  -1.4%    -580    [__TEXT]
  +0.1%    +272  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud merged commit 1092123 into next May 31, 2023
16 checks passed
@kstenerud kstenerud deleted the karl-date-formatting-ios-11 branch May 31, 2023 12:30
This was referenced Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants