Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plat-10875] Prewarm view spans #211

Merged
merged 1 commit into from Nov 22, 2023
Merged

Conversation

kstenerud
Copy link
Contributor

Goal

When view spans are started during the prewarm phase, throw them out because they'll end up with long durations that skew the dashboard stats.

Testing

Added uni tests.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.4%    +624  +0.4%    +624    String Table
  +0.5%    +516  +0.5%    +516    __TEXT,__text
  +0.5%    +448  +0.5%    +448    Symbol Table
  +1.2%    +120  +1.2%    +120    __DATA,__objc_const
  +1.1%    +113  +1.1%    +113    __TEXT,__objc_methname
  +0.8%     +72  +0.8%     +72    __TEXT,__gcc_except_tab
  +0.9%     +64  +0.9%     +64    __DATA,__cfstring
  +0.7%     +64  +0.7%     +64    __TEXT,__objc_stubs
  +0.6%     +24  +0.6%     +24    __TEXT,__unwind_info
  +0.7%     +16  +0.7%     +16    __DATA,__objc_selrefs
  +1.1%      +8  +1.1%      +8    Rebase Info
  +2.0%      +4  +2.0%      +4    __DATA,__objc_ivar
  +0.0%      +2  +0.0%      +2    __TEXT,__cstring
  -4.1%    -204  -4.2%    -204    [__DATA]
  -2.3%    -791  -2.3%    -791    [__TEXT]
  [ = ]       0 -10.5% -1.05Ki    [__LINKEDIT]
  +0.2% +1.05Ki  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud force-pushed the PLAT-10875-prewarm-view-span-2 branch 2 times, most recently from cd28f10 to 0e8d1bd Compare November 14, 2023 10:28
@kstenerud kstenerud force-pushed the PLAT-10875-prewarm-view-span-2 branch 2 times, most recently from 40acf2e to a0266cc Compare November 22, 2023 11:40
@kstenerud kstenerud force-pushed the PLAT-10875-prewarm-view-span-2 branch from a0266cc to 8161294 Compare November 22, 2023 13:39
@kstenerud kstenerud merged commit 474002b into next Nov 22, 2023
24 checks passed
@kstenerud kstenerud deleted the PLAT-10875-prewarm-view-span-2 branch November 22, 2023 14:14
@kstenerud kstenerud mentioned this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants