Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-11456] Make sure all paths of weak span list are protected with a mutex #238

Merged
merged 1 commit into from Jan 22, 2024

Conversation

kstenerud
Copy link
Contributor

The count method of weak span list wasn't protected by a mutex, causing TSAN issues.

Copy link

BugsnagPerformance.framework binary size increased by 152 bytes from 489,664 to 489,816

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%     +80  +0.1%     +80    Symbol Table
  +0.1%     +76  +0.1%     +76    __TEXT,__text
  +0.0%     +72  +0.0%     +72    String Table
  +0.0%      +4  +0.0%      +4    __TEXT,__gcc_except_tab
  +0.1%      +4  +0.1%      +4    __TEXT,__unwind_info
  -0.3%     -84  -0.3%     -84    [__TEXT]
  [ = ]       0  -8.2%    -152    [__LINKEDIT]
  +0.0%    +152  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud changed the title Make sure all paths of weak span list are protected with a mutex [PLAT-11456] Make sure all paths of weak span list are protected with a mutex Jan 17, 2024
@kstenerud kstenerud merged commit 50d5d60 into next Jan 22, 2024
21 checks passed
@kstenerud kstenerud deleted the karl-fix-weak-list branch January 22, 2024 11:03
This was referenced Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants