Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-9798] Simplified BugsnagPerformance.start API #64

Merged

Conversation

robert-smartbear
Copy link
Contributor

Goal

Simplify BugsnagPerformance.start API

Changeset

Since there’s only one user-controllable thing that can go wrong when BugsnagPerformance starts, we don’t really need the complication of declared Swift errors and return status values.

Testing

Unit Tests

@github-actions
Copy link

github-actions bot commented Mar 13, 2023

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]      +4  +3.1%    +220    [__LINKEDIT]
  +3.9%     +88  +3.9%     +88    Binding Info
  +2.5%     +88  +2.5%     +88    __TEXT,__cstring
  +0.4%     +63  +0.4%     +63    [__TEXT]
  +1.2%     +32  +1.2%     +32    Lazy Binding Info
  +0.1%     +32  +0.1%     +32    Symbol Table
  +0.7%     +32  +0.7%     +32    __DATA,__cfstring
  +0.5%     +32  +0.5%     +32    __TEXT,__objc_stubs
  +0.3%     +16  +0.3%     +16    __TEXT,__objc_methname
  +1.4%     +12  +1.4%     +12    Indirect Symbol Table
  +1.0%     +12  +1.0%     +12    __TEXT,__stub_helper
  +1.0%     +12  +1.0%     +12    __TEXT,__stubs
  +6.2%      +8  +6.2%      +8    __DATA,__got
  +1.0%      +8  +1.0%      +8    __DATA,__la_symbol_ptr
  +2.4%      +8  +2.4%      +8    __DATA,__objc_classrefs
  -1.5%     -27  -1.5%     -27    __TEXT,__objc_methtype
  -0.5%     -28  -0.5%     -28    __TEXT,__gcc_except_tab
  -0.4%     -64  -0.4%     -64    [__DATA]
  -0.3%    -160  -0.3%    -160    __TEXT,__text
  -0.5%    -384  -0.5%    -384    String Table
  -0.1%    -216  [ = ]       0    TOTAL

Generated by 🚫 Danger

@robert-smartbear robert-smartbear merged commit e07e278 into next Mar 14, 2023
@robert-smartbear robert-smartbear deleted the robert/plat-9798_simplify_bugsnagperformance_start branch March 14, 2023 08:03
@kstenerud kstenerud mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants