[PLAT-6132] Fix incorrect freeMemory for handled errors #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
kstenerud
requested changes
Mar 4, 2021
kattrali
approved these changes
Mar 5, 2021
nickdowell
changed the title
Merged
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes a bug where handled errors (those reported via
notify()) included an incorrect value forfreeMemoryChangeset
The root cause was
-[BSG_KSSystemInfo systemInfo]not includingbsg_ksmachfreeMemory()andBugsnagDeviceWithStateincorrectly falling back to the "usable" value instead.Testing
Added E2E and unit test cases that replicate the problem, and verified they pass after the fix.
Manually verified that handled errors now contain
freeMemory < totalMemory