Swift fatal error improvements #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
changed the title
kattrali
approved these changes
Sep 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Improve parsing of Swift fatal error messages.
One of our E2E tests was failing on certain OS / Swift versions because the "Unexpectedly found nil while unwrapping an Optional value" message did not contain file name and line information, which
BugsnagErrorwas expecting.Changeset
__SwiftNativeNSErroror_SwiftNativeNSError, and the name of internal methods can vary.Testing
Added macOS 10.13 barebones tests (which were failing) to the standard pipeline. Tests now pass 馃帀